Skip to content

Comments

refactor: move KServe tests from apps to tests/gh-actions#3120

Merged
google-oss-prow[bot] merged 6 commits intokubeflow:masterfrom
madmecodes:refactor/reorder-kserve-test-directory
Apr 30, 2025
Merged

refactor: move KServe tests from apps to tests/gh-actions#3120
google-oss-prow[bot] merged 6 commits intokubeflow:masterfrom
madmecodes:refactor/reorder-kserve-test-directory

Conversation

@madmecodes
Copy link
Contributor

@madmecodes madmecodes commented Apr 29, 2025

✏️ Summary of Changes

This PR centralizes all KServe testing code by:

  1. Moving Python test files from apps/kserve/tests/ to tests/gh-actions/kserve/
  2. Creating a new tests/gh-actions/test_kserve.sh script that handles setup
  3. Updating workflow file to use the new test organization

This refactoring aligns KServe tests with the project's established patterns,
reduces code duplication, and makes tests more maintainable.

📦 Dependencies

none

🐛 Related Issues

#3101 (comment)
#3098 (comment)

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@madmecodes
Copy link
Contributor Author

madmecodes commented Apr 29, 2025

@juliusvonkohout refactoring is done, now i am looking into 404 path based routing and why are the test passing even with 404, shall i do path based in this PR only or a follow up PR?

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Apr 29, 2025

@juliusvonkohout refactoring is done, now i am looking into 404 path based routing and why are the test passing even with 404, shall i do path based in this PR only or a follow up PR?

first you need to also adjust https://github.com/madmecodes/manifests/blob/61974d2186d3a45de192a5a3412f70ac5c128e3c/.github/workflows/full_kubeflow_integration_test.yaml#L167 and then we can merge this PR.

@madmecodes
Copy link
Contributor Author

madmecodes commented Apr 30, 2025

@juliusvonkohout looking forward for the feedback.

@google-oss-prow google-oss-prow bot added size/XXL and removed size/L labels Apr 30, 2025
madmecodes and others added 6 commits April 30, 2025 19:32
@madmecodes @juliusvonkohout
refactor: move KServe tests from apps to tests/gh-actions
9cc1036 
Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
@madmecodes @juliusvonkohout
update: executable permission
33c325d 
Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
@madmecodes @juliusvonkohout
update: kserve test in e2e
ff50edf 
Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
@juliusvonkohout
Update test_kserve.sh
97acf47 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Update test_kserve.sh
431025a 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Update install_katib.sh
e139c3f 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout juliusvonkohout force-pushed the refactor/reorder-kserve-test-directory branch from 2852b0d to e139c3f Compare April 30, 2025 17:33
@google-oss-prow google-oss-prow bot added size/L and removed size/XXL labels Apr 30, 2025
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Apr 30, 2025

Thank you
/approve
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 30, 2025
@google-oss-prow
Copy link

google-oss-prow bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 53724ce into kubeflow:master Apr 30, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusvonkohout juliusvonkohout Awaiting requested review from juliusvonkohout

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees

@juliusvonkohout juliusvonkohout

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@madmecodes @juliusvonkohout